Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert follower cancellation propagation (#99) #122

Merged

Conversation

clue
Copy link
Member

@clue clue commented Jun 8, 2018

This PR reverts follower cancellation propagation as implemented in #99. After discussing this feature with @jsor we agreed that the concept makes perfect sense, but the implementation is currently incomplete and also doesn't quite fit the scope of the v2.6 release right now. As such, we agreed to revert these changes for now and re-consider this for a future version instead.

@clue clue added this to the v2.6.0 milestone Jun 8, 2018
@WyriHaximus WyriHaximus merged commit 8361389 into reactphp:2.x Jun 8, 2018
@clue clue deleted the revert-cancellation-propagation branch June 8, 2018 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants