Update test suite to improve PHP 8.4+ support #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be honest, I'm nor quite sure if this is the best way to go about this. I looked for ways to test against all PHP versions in the same |
|
Seems like there's no need for additional files afterall, thanks @clue for taking a look at this with me 👍 |
clue
approved these changes
May 22, 2024
WyriHaximus
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates hour test suite to improve support with the upcoming PHP 8.4 release. In particular, the new version breaks BC as it changes the stack trace, which we test for in some of our
phptfiles.The PHP 8.4 version is currently still in development, hence I didn't add this to our test matrix to avoid any additional PHP 8.4 feature release breaking something. I explained more about this in #260. I can assure that I have tested this with PHP 8.4 and all tests run successfully with my suggested change.
Builds on top of #248, #258, #259, #260 and others