New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emmit small socket datas #289
Conversation
data test updated -> handleData($stream)
@@ -1,5 +1,5 @@ | |||
{ | |||
"name": "react/react", | |||
"name": "artydev/react", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated change
Can you add a unit test that demonstrates this fix and fails on the existing code please? |
So, after a long debugging phase, I found out the problem occurs when sending data from a socket in python language. I don't really know where is the difference between a socket in php and in python, Even after analysing the packets, I can't see any differences ... |
Excellent test case! Here's what I think is happening:
Your fix is good, it will check the read buffer and then check if it was closes. I'm going to attempt to re-work the unit test to use PHP and then merge it. |
It's probably something like that, maybe a deeper analysis of the packets could confirm. |
I ended up cherry picking (I know, scold me) your changes into the 0.4 branch, replacing with a phpunit test, tagged v0.4.1, and merged back into master. Thanks @artydev! |
Just for reference I also made a slight fix: ebf704e#diff-77e069da74242a16d316721cb77c42beR14 |
fix #288
data test updated -> handleData($stream)