Improve error reporting when DNS lookup fails (happy eyeballs) #230
+45
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes a fatal error with legacy PHP 5 where it would fail with a (catchable) fatal error when either DNS lookup fails. During test runs, this would automatically be turned into an Exception and would successfully reject the promise. Without an appropriate error handler, a soft DNS error (such as when IPv6 is not available) would previously terminate the program with a fatal error.
WyriHaximus
approved these changes
May 11, 2020
jsor
approved these changes
May 11, 2020
This was referenced May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve error reporting when DNS lookup fails (happy eyeballs). The rejection message now always contains the underlying DNS error message with more details.
Also fixes a fatal error with legacy PHP 5 where it would fail with a
(catchable) fatal error when either DNS lookup fails. During test runs,
this would automatically be turned into an Exception and would
successfully reject the promise. Without an appropriate error handler, a
soft DNS error (such as when IPv6 is not available) would previously
terminate the program with a fatal error.
Builds on top of #224 and #225
Refs #171 and others