Add pause() and resume() methods to limit active connections #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WyriHaximus
approved these changes
Mar 26, 2017
jsor
approved these changes
Mar 27, 2017
clue
added a commit
to clue-labs/socket
that referenced
this pull request
Mar 29, 2017
Remove superfluous and undocumented ConnectionException
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pause()andresume()methods can be used to limit the number of active connections.This can be used to stop accepting incoming connections once a certain limit is reached, so that the operating system backlog is responsible for managing pending connections.
I've prepared a follow-up PR for adds a simple API to control the maximum number of active connections.