Test Mac OS X on Travis #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Squashed by @clue, originally from reactphp/socket#124
|
I can't vote on my own PR, but I'm tempted to suggest we reject this PR. While I do think testing against Mac OS X adds some value, I'm not sure it's worth the wait, as Travis currently takes around 15-20min to start a single Mac OS X build. I would suggest closing this PR and let me cherry-pick the actual test fix as a separate PR? What do you think about this? |
|
@clue actually I don't mind that wait since we generally don't respond within the time it takes Travis to run that OS X build |
jsor
approved these changes
Oct 10, 2017
This was referenced Jan 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed by @clue, originally from
reactphp/socket#124
Resolves / closes #111