add stream_set_blocking for objects of type stream to limit boilerplate #9
+17
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for creating non-blocking io.
Decided to add a PR for this after talking with @cboden on IRC. It seems like it would be beneficial to have Stream always set stream_set_blocking for all stream types.
This would eliminate the need for:
https://github.com/reactphp/socket/blob/master/src/Server.php#L46
as Connection is of type Stream and the construction occurs:
https://github.com/reactphp/socket/blob/master/src/Server.php#L69
The benefit of this is that we can now do things like this: