Update Pull Request template

[muzaffar640]

First thing, PLEASE READ THIS: ReactPlay Code Review Checklist

Description

Added Screebshot or example output block to Pull Request Template

Fixes # 599

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checked the output on VS Code using command+shift+v

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Screenshots or example output

[vercel]

@muzaffar640 is attempting to deploy a commit to a Personal Account owned by @reactplay on Vercel.

@reactplay first needs to authorize it.

[muzaffar640]

Review Ready

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
react-play	✅ Ready (Inspect)	Visit Preview	Oct 6, 2022 at 4:44AM (UTC)

[atapas]

@muzaffar640 This is good but I am thinking, can we go yml way so that it becomes more like form filling for the contributors? Are you aware of that template creation?

[muzaffar640]

@muzaffar640 This is good but I am thinking, can we go yml way so that it becomes more like form filling for the contributors? Are you aware of that template creation?

No @atapas, I'm not aware of that. Can share some references, please?

[atapas]

@muzaffar640 This is good but I am thinking, can we go yml way so that it becomes more like form filling for the contributors? Are you aware of that template creation?

No @atapas, I'm not aware of that. Can share some references, please?

Like this: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/syntax-for-githubs-form-schema

[muzaffar640]

@atapas I am playing around with it. From the documentation, I'm able to create various issue templates in yml way. And as you said it is looking really good 😁 . But for PR template, I have tried various methods to render the yml file but could not able to succeed. And didn't find any valid documentation also. Can you please help me with this one? Here is my test repo

I want to update the issue template also if suggest. Please have a look at this.

Screen.Recording.2022-10-08.at.1.27.13.PM.mov

[atapas]

@atapas I am playing around with it. From the documentation, I'm able to create various issue templates in yml way. And as you said it is looking really good 😁 . But for PR template, I have tried various methods to render the yml file but could not able to succeed. And didn't find any valid documentation also. Can you please help me with this one? Here is my test repo

I want to update the issue template also if suggest. Please have a look at this.

Screen.Recording.2022-10-08.at.1.27.13.PM.mov

It seems this support is for the issue alone. I also tried the PR template but not successful. Let us then do these.

• Will go ahead with your suggested changes for PR template you made originally.
• Change the issue templates.

We will continue the PR template using YAML in a separate issue. Does it sound good?

[muzaffar640]

@atapas I am playing around with it. From the documentation, I'm able to create various issue templates in yml way. And as you said it is looking really good 😁 . But for PR template, I have tried various methods to render the yml file but could not able to succeed. And didn't find any valid documentation also. Can you please help me with this one? Here is my test repo
I want to update the issue template also if suggest. Please have a look at this.
Screen.Recording.2022-10-08.at.1.27.13.PM.mov

It seems this support is for the issue alone. I also tried the PR template but not successful. Let us then do these.

• Will go ahead with your suggested changes for PR template you made originally.
• Change the issue templates.

We will continue the PR template using YAML in a separate issue. Does it sound good?

That will be better. I will create a new issue and PR for Create Issue Template with yml then. Thanks for the confirmation.

[koustov]

@atapas is it ready to go in?