Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Pull Request template #614

Merged
merged 3 commits into from
Oct 29, 2022
Merged

Update Pull Request template #614

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
64f1270
add screenshot/screenshare block to PR template
muzaffar640 Oct 5, 2022
e94bfd6
Merge branch 'main' into update/pull_request_template
muzaffar640 Oct 8, 2022
1ed4c53
Merge branch 'main' into update/pull_request_template
Sachin-chaurasiya Oct 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

> First thing, PLEASE READ THIS: [ReactPlay Code Review Checklist](https://github.com/reactplay/react-play/wiki/ReactPlay-Code-Review-Checklist)

# Description
Expand All @@ -18,7 +17,7 @@ Please delete options that are not relevant.

# How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

# Checklist:

Expand All @@ -29,3 +28,9 @@ Please describe the tests that you ran to verify your changes. Provide instructi
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged and published in downstream modules

# Screenshots or example output

<!--- If you made any visual changes, include screenshot. -->
<!-- If you made any workflow changes, include a screenshare -->
<!--- If not relevant, delete this section. -->