Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally hide modal backdrop in Modal #134

Closed
ajainarayanan opened this issue Sep 13, 2016 · 0 comments · Fixed by #135 or #140
Closed

Optionally hide modal backdrop in Modal #134

ajainarayanan opened this issue Sep 13, 2016 · 0 comments · Fixed by #135 or #140

Comments

@ajainarayanan
Copy link
Contributor

Issue description

  • While using Modal it would be nice if Modal has an option to hide the backdrop. Right now it is compulsorily shown and there is no way to configure the Modal to not show the backdrop.

Could be similar to bootstrap v4 modal

  • version 3.1.0
  • components: Modal
TheSharpieOne added a commit to TheSharpieOne/reactstrap that referenced this issue Sep 13, 2016
@TheSharpieOne
feat(modal): add backdrop options
58b6716 
Closes reactstrap#134
Adds backdrop prop to modal with the following options
 - `true` show backdrop, close on click
 - `false` hide backdrop
 - `"static" show backdrop, do not close on click
TheSharpieOne added a commit to TheSharpieOne/reactstrap that referenced this issue Sep 13, 2016
@TheSharpieOne
feat(modal): add backdrop and keyboard options
8441b6e 
Closes reactstrap#134
Add backdrop prop to modal with the following options
 - `true` show backdrop, close on click (default)
 - `false` hide backdrop
 - `"static"` show backdrop, do not close on click
Add keyboard prop to modal with the following options
 - `true` close on escape (default)
 - `false` do not close on escape

Add tests and docs
@TheSharpieOne TheSharpieOne mentioned this issue Sep 13, 2016
Merged
eddywashere pushed a commit that referenced this issue Sep 14, 2016
@TheSharpieOne @eddywashere
feat(modal): add backdrop and keyboard options (#135)
7bf5d0a 
Closes #134
Add backdrop prop to modal with the following options
 - `true` show backdrop, close on click (default)
 - `false` hide backdrop
 - `"static"` show backdrop, do not close on click
Add keyboard prop to modal with the following options
 - `true` close on escape (default)
 - `false` do not close on escape

Add tests and docs
@eddywashere eddywashere mentioned this issue Sep 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@ajainarayanan