feat(modal): add backdrop and keyboard options #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes reactstrap#134 Add backdrop prop to modal with the following options - `true` show backdrop, close on click (default) - `false` hide backdrop - `"static"` show backdrop, do not close on click Add keyboard prop to modal with the following options - `true` close on escape (default) - `false` do not close on escape Add tests and docs
| @@ -34,7 +34,7 @@ export default class TabContent extends Component { | |||
| const classes = classnames('tab-content', this.props.className); | |||
| return ( | |||
| <div className={classes}> | |||
| { this.props.children } | |||
There was a problem hiding this comment.
The spaces between the curly and the var was given me a linter error when running the tests.
There was a problem hiding this comment.
For some reason it didn't throw me this error. Not sure if @eddywashere saw this when he released 3.1.0.
There was a problem hiding this comment.
missed it, maybe it needs option to exit properly in build step
|
@TheSharpieOne That was super quick! Thanks! |
|
great additions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #134
Add backdrop prop to modal with the following options
trueshow backdrop, close on click (default)falsehide backdrop"static"show backdrop, do not close on clickAdd keyboard prop to modal with the following options
trueclose on escape (default)falsedo not close on escapeAdd tests and docs