We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offcanvas
placement
direction
#9.0.2
👀 Offcanvas.js defines & uses the direction prop, and does not mention a placement prop:
Offcanvas.js
reactstrap/src/Offcanvas.js
Line 32 in 1179b87
Lines 412 to 414 in 1179b87
👀 OffcanvasProps.d.ts defines the placement prop, and does not define a direction prop:
OffcanvasProps.d.ts
reactstrap/types/lib/Offcanvas.d.ts
Lines 5 to 35 in 1179b87
👀 OffcanvasProps.d.ts defines the placement prop as including the values "left" | "right", but these are not valid options for the prop.
"left" | "right"
https://github.com/twbs/bootstrap/blob/7745730e4132eff204bf2afe8351511e595acee6/scss/_offcanvas.scss#L57-L90
"placement" prop appears in intellisense, but does not have any effect (prop should be "direction")
"direction" prop does not appear in intellisense (prop not defined in OffcanvasProps)
OffcanvasProps
The type definition for OffcanvasProps should match the implementation in Offcanvas.js.
I would suggest that since we use "placement" for tooltips, and the Bootstrap docs describe "placement", that we should change the implementation of Offcanvas.js to use the placement prop instead of the direction prop.
The text was updated successfully, but these errors were encountered:
fix(Offcanvas): use placement prop rather than direction prop (re…
e47569b
…actstrap#2511)
Successfully merging a pull request may close this issue.
Offcanvas
#9.0.2
What is happening?
👀
Offcanvas.js
defines & uses thedirection
prop, and does not mention aplacement
prop:reactstrap/src/Offcanvas.js
Line 32 in 1179b87
reactstrap/src/Offcanvas.js
Lines 412 to 414 in 1179b87
👀
OffcanvasProps.d.ts
defines theplacement
prop, and does not define adirection
prop:reactstrap/types/lib/Offcanvas.d.ts
Lines 5 to 35 in 1179b87
👀
OffcanvasProps.d.ts
defines theplacement
prop as including the values"left" | "right"
, but these are not valid options for the prop.https://github.com/twbs/bootstrap/blob/7745730e4132eff204bf2afe8351511e595acee6/scss/_offcanvas.scss#L57-L90
User impact
"placement" prop appears in intellisense, but does not have any effect (prop should be "direction")
"direction" prop does not appear in intellisense (prop not defined in
OffcanvasProps
)What should be happening?
The type definition for
OffcanvasProps
should match the implementation inOffcanvas.js
.I would suggest that since we use "placement" for tooltips, and the Bootstrap docs describe "placement", that we should change the implementation of
Offcanvas.js
to use theplacement
prop instead of thedirection
prop.The text was updated successfully, but these errors were encountered: