fix(Offcanvas): make types match existing direction prop

[BenJenkinson]

• Bug fix for Offcanvas has incorrect prop types for placement/direction #2511
• New feature
• Chore
• Breaking change
• There is an open issue which this change addresses
• I have read the CONTRIBUTING document.
• My commits follow the Git Commit Guidelines
• My code follows the code style of this project.
• My change requires a change to the documentation storybook example.
  • I have updated the documentation storybook example accordingly. (see here)
• My change requires a change to Typescript typings.
  • I have updated the typings accordingly. (see here)
• I have added modified existing tests to cover my changes. (see here)
• All new and existing tests passed.

Fixes #2511

[crathor]

@BenJenkinson you changed a prop this is a Breaking Change but you did not check the breaking change option 🤔

[BenJenkinson]

you changed a prop this is a Breaking Change but you did not check the breaking change option 🤔

@crathor, you're right. I have now checked that checkbox.

[davidacevedo]

Can you instead update the types to be direction so that intellisense is happy https://github.com/reactstrap/reactstrap/blob/master/types/lib/Offcanvas.d.ts. I'd rather us not make a breaking change for something small like this yet as direction is already an available prop that works while placement "doesn't exist"

[BenJenkinson]

Because we have both direction and placement, there's going to be some sort of breaking change either way.

Either JS users need to switch from direction to placement, or TS users have to switch from (valid, but non-working) placement to direction.

Ideally, I would prefer placement, as that would match the Bootstrap documentation, and match the other Tooltip/Popover components that have a placement prop.

But, I suppose we should prefer forcing a breaking change on TS users rather than JS users.

• It would only affect TS users who have tried to use the (non-working) placement prop.
• If it were the other way around, then any JS users who had used direction would silently find that their <Offcanvas/> element switched direction.

[BenJenkinson]

Hi @davidacevedo,

Are you OK with these changes?

[davidacevedo]

Looks good 👍