Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal doesn't pass style property to div #443

Closed
springuper opened this issue May 22, 2017 · 3 comments · Fixed by #444 or #479
Closed

Modal doesn't pass style property to div #443

springuper opened this issue May 22, 2017 · 3 comments · Fixed by #444 or #479

Comments

@springuper
Copy link

springuper commented May 22, 2017

Issue description

  • version #4.6.2
  • components: Modal

Steps to reproduce issue

<Modal isOpen={isOpen} toggle={this.onToggle} style={{ maxWidth: '95%' }}>

the style property doesn't apply on the final rendered div element. I checked the source code, and found that the problem does exist.

is it intended?

@TheSharpieOne
Copy link
Member

TheSharpieOne commented May 22, 2017

Due to the complexity of the render component, it doesn't look like any extra props are passed through to any of the markup. Which element would you expect to get the styles?
A similar issue with className caused the creation of props such as className, wrapClassName, modalClassName, backdropClassName, contentClassName

@springuper
Copy link
Author

springuper commented May 22, 2017

I expect the div with 'modal-dialog' class to get the styles.

Sometimes, it is really a convenience to use an inline style other than class name. And it works before,

...attributes
.

@TheSharpieOne
Copy link
Member

Looks like #339 removed that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants