-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nav prop to Dropdown #636
Add nav prop to Dropdown #636
Conversation
Move NavDropdown tests to Dropdown Remove Uncontrolled NavDropdown and tests Update docs
I updated the tests but I can't seem to run them locally. I get the following:
Any ideas? Running on a MacBook Pro, NodeJS v6.11.4, npm v5.5.1 and a fresh |
I get that on my work Mac as well. I am able run coverage which does the test but does not watch the files. Takes a little longer to run, but at least it works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for this. Just a few little things. If you cannot get to them, I can do it (let me know).
@@ -64,6 +64,7 @@ | |||
"Jason Sturges <jason@jasonsturges.com> (https://github.com/jasonsturges)", | |||
"Jean-Elie Barjonet (https://github.com/jebarjonet)", | |||
"Jeff Francisco (https://github.com/j-francisco)", | |||
"Jesse Mandel (https://github.com/supergibbs)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is generated, but eh.
src/Uncontrolled.js
Outdated
const UncontrolledTooltip = components.UncontrolledTooltip; | ||
|
||
export { | ||
UncontrolledAlert, | ||
UncontrolledButtonDropdown, | ||
UncontrolledDropdown, | ||
UncontrolledNavDropdown, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to deprecate this the same as NavDropdown
so that it is not a breaking change.
src/index.js
Outdated
@@ -6,7 +6,6 @@ import NavbarBrand from './NavbarBrand'; | |||
import NavbarToggler from './NavbarToggler'; | |||
import Nav from './Nav'; | |||
import NavItem from './NavItem'; | |||
import NavDropdown from './NavDropdown'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You still need to import this and export it so that the deprecated component can still be used (and give people the warning).
I am happy to make those changes but I am traveling for a couple weeks so
if you want to merge it in before feel free to work on it.
…On Sat, Oct 21, 2017 at 5:06 PM Evan Sharp ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Looks good. Thanks for this. Just a few little things. If you cannot get
to them, I can do it (let me know).
------------------------------
In package.json
<#636 (comment)>:
> @@ -64,6 +64,7 @@
"Jason Sturges ***@***.***> (https://github.com/jasonsturges)",
"Jean-Elie Barjonet (https://github.com/jebarjonet)",
"Jeff Francisco (https://github.com/j-francisco)",
+ "Jesse Mandel (https://github.com/supergibbs)",
I think this is generated, but eh.
------------------------------
In src/Uncontrolled.js
<#636 (comment)>:
> const UncontrolledTooltip = components.UncontrolledTooltip;
export {
UncontrolledAlert,
UncontrolledButtonDropdown,
UncontrolledDropdown,
- UncontrolledNavDropdown,
Would be nice to deprecate this the same as NavDropdown so that it is not
a breaking change.
------------------------------
In src/index.js
<#636 (comment)>:
> @@ -6,7 +6,6 @@ import NavbarBrand from './NavbarBrand';
import NavbarToggler from './NavbarToggler';
import Nav from './Nav';
import NavItem from './NavItem';
-import NavDropdown from './NavDropdown';
You still need to import this and export it so that the deprecated
component can still be used (and give people the warning).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#636 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABDhm8bqFywuILJ0Xyezb8iv3upHwnfVks5sughmgaJpZM4P5gV3>
.
|
export deprecated components
…o consolidate-navdropdown
@TheSharpieOne I'm back and made those changes! Let me know if there is anything else |
Thanks @supergibbs for making those changes. I was hoping to get around to it but have been too swamped. |
Consolidate NavDropdown with Dropdown
Move NavDropdown tests to Dropdown
Remove Uncontrolled NavDropdown and tests
Update docs
#326 (comment)