Add nav prop to Dropdown

[supergibbs]

Consolidate NavDropdown with Dropdown
Move NavDropdown tests to Dropdown
Remove Uncontrolled NavDropdown and tests
Update docs

#326 (comment)

[supergibbs]

I updated the tests but I can't seem to run them locally. I get the following:

➜  reactstrap git:(consolidate-navdropdown) ✗ npm test 

> reactstrap@5.0.0-alpha.3 test /Users/jmandel/Development/supergibbs/reactstrap
> cross-env BABEL_ENV=test react-scripts test --env=jsdom

2017-10-14 12:48 node[8340] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
2017-10-14 12:48 node[8340] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-22)
events.js:160
      throw er; // Unhandled 'error' event
      ^

Error: Error watching file for changes: EMFILE
    at exports._errnoException (util.js:1020:11)
    at FSEvent.FSWatcher._handle.onchange (fs.js:1421:9)
npm ERR! Test failed.  See above for more details.

Any ideas? Running on a MacBook Pro, NodeJS v6.11.4, npm v5.5.1 and a fresh npm install after removing node_modules/lock file

[TheSharpieOne]

I get that on my work Mac as well. I am able run coverage which does the test but does not watch the files. Takes a little longer to run, but at least it works.

[TheSharpieOne]

Looks good. Thanks for this. Just a few little things. If you cannot get to them, I can do it (let me know).

[TheSharpieOne]

I think this is generated, but eh.

[TheSharpieOne]

Would be nice to deprecate this the same as NavDropdown so that it is not a breaking change.

[TheSharpieOne]

You still need to import this and export it so that the deprecated component can still be used (and give people the warning).

[supergibbs]

I am happy to make those changes but I am traveling for a couple weeks so if you want to merge it in before feel free to work on it.

…

On Sat, Oct 21, 2017 at 5:06 PM Evan Sharp ***@***.***> wrote: ***@***.**** requested changes on this pull request. Looks good. Thanks for this. Just a few little things. If you cannot get to them, I can do it (let me know). ------------------------------ In package.json <#636 (comment)>: > @@ -64,6 +64,7 @@ "Jason Sturges ***@***.***> (https://github.com/jasonsturges)", "Jean-Elie Barjonet (https://github.com/jebarjonet)", "Jeff Francisco (https://github.com/j-francisco)", + "Jesse Mandel (https://github.com/supergibbs)", I think this is generated, but eh. ------------------------------ In src/Uncontrolled.js <#636 (comment)>: > const UncontrolledTooltip = components.UncontrolledTooltip; export { UncontrolledAlert, UncontrolledButtonDropdown, UncontrolledDropdown, - UncontrolledNavDropdown, Would be nice to deprecate this the same as NavDropdown so that it is not a breaking change. ------------------------------ In src/index.js <#636 (comment)>: > @@ -6,7 +6,6 @@ import NavbarBrand from './NavbarBrand'; import NavbarToggler from './NavbarToggler'; import Nav from './Nav'; import NavItem from './NavItem'; -import NavDropdown from './NavDropdown'; You still need to import this and export it so that the deprecated component can still be used (and give people the warning). — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#636 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABDhm8bqFywuILJ0Xyezb8iv3upHwnfVks5sughmgaJpZM4P5gV3> .

[supergibbs]

@TheSharpieOne I'm back and made those changes! Let me know if there is anything else

[TheSharpieOne]

Thanks @supergibbs for making those changes. I was hoping to get around to it but have been too swamped.