Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel sometimes animates in wrong direction when clicking indicators #748

Closed
bmey opened this issue Dec 22, 2017 · 0 comments
Closed
Labels
Projects

Comments

@bmey
Copy link
Contributor

bmey commented Dec 22, 2017

Carousel sometimes animates in wrong direction when clicking indicators

  • components: Carousel

What is happening?

Example scenario: Carousel has 3 slides and is using indicators. Active slide is the third. When a user clicks on the first indicator, the carousel animates to the right.

What should be happening?

It should be animating to the left. I tested it out on Bootstrap's website, and this is how their carousels work.

http://getbootstrap.com/docs/4.0/components/carousel/

This is even more apparent if there are more than 3 slides (lets say 5), and the user clicks on any indicator more than one slide away. The same problem persists. The carousel will animate in the opposite direction of what you would expect.

Steps to reproduce issue

  1. Click on an indicator more than one slide from active slide
  2. Animation occurs in wrong direction

Error message in console

N/A

Code

https://github.com/bmey/reactstrap/blob/95026f4af07ebebf6359b3d7add4ec584e002204/src/Carousel.js#L38-L42

PR to fix the issue: #749

@supergibbs supergibbs added the bug label Jan 31, 2018
@supergibbs supergibbs added this to To Do in v5.0.0 via automation Jan 31, 2018
v5.0.0 automation moved this from To Do to Done Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
v5.0.0
  
Done
Development

No branches or pull requests

2 participants