fix(Carousel): fix animation direction when using `CarouselIndicators… #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSharpieOne
approved these changes
Mar 23, 2018
There was a problem hiding this comment.
This looks good, but I am just going to note that if the click set indicatorClicked but the user defined toggle method determines to take no action, indicatorClicked will remain set to true for the next action.
We may want to do something similar for the controlLeft and controlRight in the future if this becomes an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…` (#748).
The approach I took is to add a state property in Carousel that gets set when indicator children are clicked. I'm open to other approaches, but this seemed like the simplest change with the current structure.