Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse #79

Closed
1 task done
eddywashere opened this issue Jul 31, 2016 · 13 comments
Closed
1 task done

Collapse #79

eddywashere opened this issue Jul 31, 2016 · 13 comments
Labels
help wanted up-for-grabs
Milestone
Stable Release

Comments

@eddywashere
Copy link
Member

eddywashere commented Jul 31, 2016 •
edited

http://v4-alpha.getbootstrap.com/components/collapse/
@eddywashere eddywashere added this to the Stable Release milestone Jul 31, 2016
@eddywashere
Copy link
Member Author

Todo: list transition states and classes. I looked at this for a bit and I think there's something more to just adding and removing classes during these states. I believe there is a height inline style applied before showing the content.

@LiJinyao
Copy link
Contributor

I'd like to build this component😊, can you assign it to me?

@lvauvillier
Copy link
Contributor

Humm, I didn't see this issue before sending a PR (#190) for the navbar.
Maybe I can help here and update it to do a more generic one with a Collapse component

@LiJinyao
Copy link
Contributor

LiJinyao commented Oct 20, 2016 •
edited

Ops, My work almost finished. Maybe you can have a look at https://github.com/LiJinyao/reactstrap/blob/collapse/src/Collapse.js, I write a simple demo for it in doc but I haven't finish test yet.

@eddywashere
Copy link
Member Author

@lvauvillier I saw the pr. I was going to suggest that you use or look into the work @LiJinyao is doing. Thanks for the update @LiJinyao. Let me know if you need anything. Component is looking good. I'll try it out as soon as I get some free time. Traveling this week until Monday.

@lvauvillier
Copy link
Contributor

@LiJinyao thanks for your work, I'll try it with the navbar toggler.
@eddywashere If all works fine, I'll update my PR using the new Collapse component. (My PR will finally just be a doc update for the navbar toogler use case)

@lvauvillier
Copy link
Contributor

lvauvillier commented Oct 24, 2016 •
edited

@LiJinyao, your Collapse component is working fine
I created a branch with a sample mixing Collapse and the navbarToggler here : https://github.com/lvauvillier/reactstrap/tree/NavbarToggler-sample

Ready to PR when your component will officially be available.

@lvauvillier lvauvillier mentioned this issue Oct 24, 2016
Closed
@LiJinyao
Copy link
Contributor

@lvauvillier Good job! I'll make a PR toady.

eddywashere pushed a commit that referenced this issue Nov 1, 2016
@LiJinyao @eddywashere
feat(Collapse): add Collapse component #79 (#201)
ddbf0dd 
* init collapse

* add collapse animation

* add margin between toggle button and collapse

* disable lint on force refresh DOM line.

* add test to Collapse

* remove height after shown

* Revert "remove height after shown"

This reverts commit eff9353.

* remove height after shown.

* add more test

* use setState() to set inline height style

* remove custom tag in doc

* add inline style test

* remove comment

* set height to null when isOpen is true

* add initial state test
@eddywashere eddywashere mentioned this issue Nov 1, 2016
Merged
@eddywashere
Copy link
Member Author

released in 3.8.0, thanks @LiJinyao!

eddywashere pushed a commit that referenced this issue Nov 2, 2016
@edgji @eddywashere
docs(NavbarToggler): add NavbarToggler example with Collapse Component (
997d36f 
#216)

* add NavbarToggler example

* feat(Collapse): add Collapse component #79 (#201)

* init collapse

* add collapse animation

* add margin between toggle button and collapse

* disable lint on force refresh DOM line.

* add test to Collapse

* remove height after shown

* Revert "remove height after shown"

This reverts commit eff9353.

* remove height after shown.

* add more test

* use setState() to set inline height style

* remove custom tag in doc

* add inline style test

* remove comment

* set height to null when isOpen is true

* add initial state test

* chore(release): adding 3.8.0 (#217)

* chore(release): adding 3.8.0

* feat(Collapse): add cssModule support

* feat(refs): add getRef to focusable components (#218)

* chore(release): adding 3.8.1 (#219)

* add NavbarToggler example

* update example to use Collapse component
@gthomas-appfolio
Copy link
Contributor

FYI bootstrap v5 alpha now uses collapse active instead of collapse in:

twbs/bootstrap#21019

What's the proper way to follow up with these changes in the reactstrap codebase? PR as they are made in BS4 or you wait for certain milestones?

@eddywashere
Copy link
Member Author

@gthomas-appfolio thanks for the heads up! There's nothing official about this for reactstrap. PRs for official upcoming changes are more than welcomed. We can label them as waiting-on-bs4-release or something more appropriate. They can be shipped as soon it's released upstream.

Does that work for you? Or are you looking for something like a prerelease branch for stuff in twbs:v4-dev (bs4 latest).

@eddywashere
Copy link
Member Author

@gthomas-appfolio tracking these changes over at #224.

@gthomas-appfolio
Copy link
Contributor

Sorry just saw, sounds great @eddywashere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted up-for-grabs
Projects
None yet
Milestone
Stable Release
Development

No branches or pull requests
4 participants
@lvauvillier @eddywashere @LiJinyao @gthomas-appfolio