-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse #79
Comments
Todo: list transition states and classes. I looked at this for a bit and I think there's something more to just adding and removing classes during these states. I believe there is a height inline style applied before showing the content. |
I'd like to build this component😊, can you assign it to me? |
Humm, I didn't see this issue before sending a PR (#190) for the navbar. |
Ops, My work almost finished. Maybe you can have a look at https://github.com/LiJinyao/reactstrap/blob/collapse/src/Collapse.js, I write a simple demo for it in doc but I haven't finish test yet. |
@lvauvillier I saw the pr. I was going to suggest that you use or look into the work @LiJinyao is doing. Thanks for the update @LiJinyao. Let me know if you need anything. Component is looking good. I'll try it out as soon as I get some free time. Traveling this week until Monday. |
@LiJinyao thanks for your work, I'll try it with the navbar toggler. |
@LiJinyao, your Collapse component is working fine Ready to PR when your component will officially be available. |
@lvauvillier Good job! I'll make a PR toady. |
* init collapse * add collapse animation * add margin between toggle button and collapse * disable lint on force refresh DOM line. * add test to Collapse * remove height after shown * Revert "remove height after shown" This reverts commit eff9353. * remove height after shown. * add more test * use setState() to set inline height style * remove custom tag in doc * add inline style test * remove comment * set height to null when isOpen is true * add initial state test
released in 3.8.0, thanks @LiJinyao! |
#216) * add NavbarToggler example * feat(Collapse): add Collapse component #79 (#201) * init collapse * add collapse animation * add margin between toggle button and collapse * disable lint on force refresh DOM line. * add test to Collapse * remove height after shown * Revert "remove height after shown" This reverts commit eff9353. * remove height after shown. * add more test * use setState() to set inline height style * remove custom tag in doc * add inline style test * remove comment * set height to null when isOpen is true * add initial state test * chore(release): adding 3.8.0 (#217) * chore(release): adding 3.8.0 * feat(Collapse): add cssModule support * feat(refs): add getRef to focusable components (#218) * chore(release): adding 3.8.1 (#219) * add NavbarToggler example * update example to use Collapse component
FYI bootstrap v5 alpha now uses What's the proper way to follow up with these changes in the reactstrap codebase? PR as they are made in BS4 or you wait for certain milestones? |
@gthomas-appfolio thanks for the heads up! There's nothing official about this for reactstrap. PRs for official upcoming changes are more than welcomed. We can label them as Does that work for you? Or are you looking for something like a prerelease branch for stuff in |
@gthomas-appfolio tracking these changes over at #224. |
Sorry just saw, sounds great @eddywashere |
http://v4-alpha.getbootstrap.com/components/collapse/
The text was updated successfully, but these errors were encountered: