Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Col with CSS Module Incorrectly Generates Classnames with object columnprop #856

Closed
thegeebe opened this issue Feb 22, 2018 · 0 comments
Closed

Comments

@thegeebe
Copy link
Contributor

Issue description

  • components: Col

What is happening?

A misplaced parenthesis here is passing cssModule to mapToCssModules incorrectly in Col when using an object-style columnProp. Instead, cssModule is pushed on to the stack of colClasses, and thus the second time classNames is called, all classnames in the module will be placed in the joined classname (since the values are truthy), so the col gets all classes in the cssModule.

What should be happening?

The module should be supplied to mapToCssModules and only the relevant classes should be appended.

Steps to reproduce issue

  1. Configure css modules in build and import styles
  2. Create a column with an object as the columnProp e.g. <Col cssModule={style} lg={{size: 8, offset: 2}}>hello</Col>

I'll issue a PR now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant