Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing toggle to Accordion #2642

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Added missing toggle to Accordion #2642

merged 2 commits into from
Jul 13, 2023

Conversation

ml054
Copy link
Contributor

@ml054 ml054 commented Nov 10, 2022

Added missing toggle property to accordion. W/o that we have prop types issue:

 Failed prop type: The prop `toggle` is marked as required in `Accordion`, but its value is `undefined`.

See here:

toggle: PropTypes.func.isRequired,

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Collaborator

@davidacevedo davidacevedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@Samettkaya
Copy link

Hello, the problem here is version 9.1.5, which version does it work in?

@ml054
Copy link
Contributor Author

ml054 commented Dec 12, 2022

PR is still open... :) So if might work if you manually build version with this PR

@ml054
Copy link
Contributor Author

ml054 commented May 15, 2023

Any update on that? I wish I could have clean console during test runs. Can you help me with that?

@ml054
Copy link
Contributor Author

ml054 commented Jun 21, 2023

?

@aaronmars aaronmars merged commit 61f2453 into reactstrap:master Jul 13, 2023
@ml054
Copy link
Contributor Author

ml054 commented Sep 25, 2023

Woo hoo, looks like it was already merged. When can I expect this in stable release? We are so close to clean console output. Let's make that happen. :)

@kpull1
Copy link

kpull1 commented Nov 8, 2023

It's been a year since this problem has been fixed and it's not released yet. Is anybody using the Accordion?
I've tried by myself and this patch breaks the UncontrolledAccordion.
It lacks to add the toggle in the Omit<AccordionProps, 'open' | 'toggle'>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants