Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing prop in Accordion types #2761

Closed
wants to merge 1 commit into from
Closed

fix: add missing prop in Accordion types #2761

wants to merge 1 commit into from

Conversation

aaronmars
Copy link
Collaborator

Added the toggle function type to Accordion.d.ts. This prop already exists in the propTypes definition in Accordion.js

  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aaronmars
Copy link
Collaborator Author

Duplicate of #2642

@aaronmars aaronmars marked this as a duplicate of #2642 Jul 13, 2023
@aaronmars aaronmars closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidacevedo davidacevedo Awaiting requested review from davidacevedo

@illiteratewriter illiteratewriter Awaiting requested review from illiteratewriter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@aaronmars