Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2730): import error #2733

Merged
merged 1 commit into from
Apr 11, 2023
Merged

fix(#2730): import error #2733

merged 1 commit into from
Apr 11, 2023

Conversation

illiteratewriter
Copy link
Member

@illiteratewriter illiteratewriter commented Apr 6, 2023 •
edited

  • convert files to commonjs
  • Bug fix
  • New feature
  • Chore
  • Breaking change
  • There is an open issue which this change addresses
  • I have read the CONTRIBUTING document.
  • My commits follow the Git Commit Guidelines
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • My change requires a change to Typescript typings.
    • I have updated the typings accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@illiteratewriter
fix(reactstrap#2730): import error
1a7fe70 
- convert files to commonjs
@illiteratewriter illiteratewriter mentioned this pull request Apr 6, 2023
Closed
@illiteratewriter illiteratewriter merged commit 2547f3a into reactstrap:master Apr 11, 2023
This was referenced Apr 11, 2023
Merged
Merged
@github-actions github-actions bot mentioned this pull request May 13, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Merged
ksibisamir added a commit to SaTT-Wallet/Backend that referenced this pull request Jun 13, 2023
@ksibisamir
[Snyk] Upgrade reactstrap from 9.1.8 to 9.1.10 (#250)
1fe36b2 
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade reactstrap
from 9.1.8 to 9.1.10.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>

- The recommended version is **2 versions** ahead of your current
version.
- The recommended version was released **a month ago**, on 2023-05-13.


<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>reactstrap</b></summary>
    <ul>
      <li>
<b>9.1.10</b> - <a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/releases/tag/v9.1.10">2023-05-13</a></br><h2><a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/compare/v9.1.9...v9.1.10">9.1.10</a>
(2023-05-13)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong><a class="issue-link js-issue-link" data-error-text="Failed
to load title" data-id="1091321145" data-permission-text="Title is
private" data-url="reactstrap/reactstrap#2427"
data-hovercard-type="issue"
data-hovercard-url="/reactstrap/reactstrap/issues/2427/hovercard"
href="https://snyk.io/redirect/github/reactstrap/reactstrap/issues/2427">#2427</a>:</strong>
error building esm files (<a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/issues/2748"
data-hovercard-type="pull_request"
data-hovercard-url="/reactstrap/reactstrap/pull/2748/hovercard">#2748</a>)
(<a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/04d571dcaa630ccbc8b8363ad06dad436f11780e">04d571d</a>)</li>
<li>properly pass in <code>isOpen</code> in modal test (<a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/issues/2745"
data-hovercard-type="pull_request"
data-hovercard-url="/reactstrap/reactstrap/pull/2745/hovercard">#2745</a>)
(<a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/8cb051522ddfad48c08651604744caea25b5e68e">8cb0515</a>)</li>
</ul>
      </li>
      <li>
<b>9.1.9</b> - <a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/releases/tag/v9.1.9">2023-04-11</a></br><h2><a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/compare/v9.1.8...v9.1.9">9.1.9</a>
(2023-04-11)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong><a class="issue-link js-issue-link" data-error-text="Failed
to load title" data-id="1649087269" data-permission-text="Title is
private" data-url="reactstrap/reactstrap#2730"
data-hovercard-type="issue"
data-hovercard-url="/reactstrap/reactstrap/issues/2730/hovercard"
href="https://snyk.io/redirect/github/reactstrap/reactstrap/issues/2730">#2730</a>:</strong>
import error (<a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/issues/2733"
data-hovercard-type="pull_request"
data-hovercard-url="/reactstrap/reactstrap/pull/2733/hovercard">#2733</a>)
(<a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/2547f3acfd12299dc0f4e2a5863c5cf82a203ef4">2547f3a</a>)</li>
</ul>
      </li>
      <li>
<b>9.1.8</b> - <a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/releases/tag/v9.1.8">2023-03-29</a></br><h2><a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/compare/v9.1.7...v9.1.8">9.1.8</a>
(2023-03-29)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>esm and lib folder not included in release (<a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/e974d0c180ebece9e35614da595e9cab2d8684b6">e974d0c</a>)</li>
</ul>
      </li>
    </ul>
from <a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/releases">reactstrap
GitHub release notes</a>
  </details>
</details>


<details>
  <summary><b>Commit messages</b></summary>
  </br>
  <details>
    <summary>Package name: <b>reactstrap</b></summary>
    <ul>
<li><a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/a064b497a1d2410f1997a1fa83bf797b5dd08158">a064b49</a>
Merge pull request #2737 from
reactstrap/release-please--branches--master--components--reactstrap</li>
<li><a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/5e09b66971db7dc9dccc9f9c6abb36e8816bf883">5e09b66</a>
chore(master): release 9.1.10</li>
<li><a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/04d571dcaa630ccbc8b8363ad06dad436f11780e">04d571d</a>
fix(#2427): error building esm files (#2748)</li>
<li><a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/8cb051522ddfad48c08651604744caea25b5e68e">8cb0515</a>
fix: properly pass in &#x60;isOpen&#x60; in modal test (#2745)</li>
<li><a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/0169e1af45415303a3d0b144476195e27ff7527c">0169e1a</a>
Merge pull request #2729 from
reactstrap/release-please--branches--master--components--reactstrap</li>
<li><a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/3b9416473c39faf8cb5d520af4547a96648d4bf6">3b94164</a>
chore(master): release 9.1.9</li>
<li><a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/commit/2547f3acfd12299dc0f4e2a5863c5cf82a203ef4">2547f3a</a>
fix(#2730): import error (#2733)</li>
    </ul>

<a
href="https://snyk.io/redirect/github/reactstrap/reactstrap/compare/cfd0c4f834e9874ca4d94c6a5b348b7d9aadb53f...a064b497a1d2410f1997a1fa83bf797b5dd08158">Compare</a>
  </details>
</details>
<hr/>

**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJiMWU1Y2Q4OS1kMGEyLTQyMzMtYjQzYy00MGY5MTQ5NjhmMTIiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImIxZTVjZDg5LWQwYTItNDIzMy1iNDNjLTQwZjkxNDk2OGYxMiJ9fQ=="
width="0" height="0"/>

🧐 [View latest project
report](https://app.snyk.io/org/satt/project/b89486be-ad07-4d6c-a51a-2fa8a25baa00?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/satt/project/b89486be-ad07-4d6c-a51a-2fa8a25baa00/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/satt/project/b89486be-ad07-4d6c-a51a-2fa8a25baa00/settings/integration?pkg&#x3D;reactstrap&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

<!---
(snyk:metadata:{"prId":"b1e5cd89-d0a2-4233-b43c-40f914968f12","prPublicId":"b1e5cd89-d0a2-4233-b43c-40f914968f12","dependencies":[{"name":"reactstrap","from":"9.1.8","to":"9.1.10"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/satt/project/b89486be-ad07-4d6c-a51a-2fa8a25baa00?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"b89486be-ad07-4d6c-a51a-2fa8a25baa00","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":2,"publishedDate":"2023-05-13T15:05:30.024Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
@github-actions github-actions bot mentioned this pull request Nov 8, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jan 20, 2024
Open
@geekswagg geekswagg mentioned this pull request Jul 16, 2024
Merged
@tural-xanaliyev tural-xanaliyev mentioned this pull request Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronmars aaronmars aaronmars approved these changes

@davidacevedo davidacevedo Awaiting requested review from davidacevedo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@illiteratewriter @aaronmars