Should we release 0.69.1?

[cortinico]

Should we release 0.69.1?

Current Release: 0.69.0

Conversations on this thread are limited:

• major release issues.
• qualified cherry-pick requests of commits on main that did not make the previous patch version.

Please include a link to the specific commit on main to be cherry-picked, for example: facebook/react-native@bd2b7d6

In other words, if you cannot point to a particular commit on main, then your request likely belongs as a new issue.
If the issue is a major release issues, please reference the issue here.

---

List of qualified picks

• facebook/react-native@114d31f
• facebook/react-native@43f831b
• facebook/react-native@c2088e1
• facebook/react-native@f97c6a5
• facebook/react-native@79baca6
• facebook/react-native@4ea38e1

To be rolled-over to 0.69.2:

• facebook/react-native@0bd5239
• facebook/react-native@9f112af
• Mac Catalyst patches facebook/react-native#34026

Local commits to backport to main

[AlexanderEggers]

After updating to 0.69.0 I have multiple packages failing with the message which causes my build to fail:

warn Package @sentry/react-native has been ignored because it contains invalid configuration. Reason: "dependency.platforms.ios.sharedLibraries" is not allowed
warn Package expo has been ignored because it contains invalid configuration. Reason: "dependency.platforms.ios.podspecPath" is not allowed
warn Package react-native-vector-icons has been ignored because it contains invalid configuration. Reason: "dependency.assets" is not allowed
warn Package react-native-flipper has been ignored because it contains invalid configuration. Reason: "dependency.platforms.ios.project" is not allowed

When downgrading to 0.68.x, the warnings are gone and I can compile correctly again.

[thymikee]

As @tido64 mentioned. I'll look into ignoring those warnings (which are in fact errors from schema validation which prevent building the config object) from the CLI side

[kelset]

@thymikee so it sounds like a new version of CLI v.8.x.y will be needed to address this?

[thymikee]

@kelset yup. I'm trying to prioritize this, but can't just jump on it asap

[kelset]

oh yeah no rush - I'm just trying to understand where and how the fix will need to happen 🤗

[RnbWd]

it's not including these libraries, even though it's a warning

[SymntxHomendra51]

fix the problems with the flipper.

[SymntxHomendra51]

Hello Mate!
I'm referring to this problem. Dont know which issue does it belongs though
https://rnfirebase.io/#altering-cocoapods-to-use-frameworks

[lukebars]

@SymntxHomendra51 this is open source software, so usually nobody is being paid to do the work. You can always help by funding somebody to do the work or help yourself. Otherwise - just be patient, sorry. 🙏

[mikehardy]

Yep - I literally wrote that note @SymntxHomendra51 - and there are patches already for 0.69.0 and Hermes (they are in the pick list above).

But for Flipper I'm not sure it is being tracked, and it does not have a PR yet - you could be the savior and post the PR! Same for New Architecture - details here - #21 (reply in thread)

Please note that for this discussion we need commit hashes to pick. That's it. So for purposes of this discussion there is no action here yet unless/until you or someone posts a fix to Flipper that is merged to main and you comment here with the commit hash to pick. That would be fantastic - then we'll be in business

[mikehardy]

To be more prescriptive perhaps:

1. need an issue logged with Flipper such that Flipper works with use_frameworks! :linkage => :dynamic and use_frameworks! :linkage => :static - and then the associated PR produced by someone affected + motivated
2. need an issue logged with react-native to get use_frameworks! :linkage => :dynamic (and :static) working with New Architecture enabled, note this likely needs to be driven internally by Meta as it's a cross-cutting change, see [🐛] Expo - ios React Native Firebase - pod install not working invertase/react-native-firebase#6323 (comment) specifically
3. wait for 0.69.1 such that existing commits already in pick list are released, so you may use react-native-firebase v15+ along with react-native 0.69.1 (with or without hermes, but still no flipper or new architecture until 1 and 2 here are done)

@SymntxHomendra51 those are actions you can take - if you would do those and cross-link them here I will personally track them across releases etc and help where possible.

[mikehardy]

react-native-firebase v15 works (with hermes!) with react-native 0.69.0 if you apply this patch-package patch - which is itself the product of @Kudo - but now it is easy to digest and I've qualified the two pick requests, it looks like it's good. That was item 3 in my previous comment. Items 1 and 2 are still work to do

[AlirezaHadjar]

Hi,
according to the changelog, the link command and react-native-config.js were removed. So how should we add a font to our project? should we do it manually or there is another way?

[tido64]

Please see this discussion: #21 (comment)

[opayen]

We would like to have facebook/react-native@114d31f cherry-picked to 0.69.1.
It is a fix to a regression that was introduced in 0.68 (see facebook/react-native#33977)

[fortmarek]

Yes, it's already in the list of commits to pick, thanks 🙌

[kelset]

let's not forget facebook/react-native#34026 cc @mikehardy @Arkkeeper

[cortinico]

ETA for merging this is Monday/Tuesday next week. I'll add it to the list of pick

[oleksandr-dziuban]

Hi guys, please review a critical issues for Android 12 please
Native crash for Animated Nodes
facebook/react-native#33375

[oleksandr-dziuban]

It affects all RN applications on Android 12. A lot of apps are crashing.... we don't have a workaround yet..

[mikehardy]

we don't have a workaround yet

It's worse than that, there is not even a reproduction. First step: reproduction. Second step: PR against react-native@main merged. Third Step: join discussion here on whether it is appropriate to cherry-pick the commit from second step

Discussing it here is unfortunately quite premature. I posted on your issue though just to offer that there may be hope for a repro if you try samsung's device test lab. Get a commit hash from a merged commit related to that issue then this is the spot

[leotm]

just following up to not forget

• Road to 0.69.0 #21 (comment)

facebook/react-native@0bd5239 looks like the worthy one
(facebook/react-native@9f112af a follow-up commit)

worth noting the minor template update there ahead of time too
which will land on upgrade-helper on ship

[cortinico]

This had to be backported in a different PR. Kudos to @cipolleschi for doing so here:

• [fix] backport FlipperConfiguration from main facebook/react-native#34098

Will land in 0.69.2

[kelset]

surfacing here, seems there's an ongoing issue with Yoga: facebook/react-native#33976 (cc @Bardiamist)

[kelset]

did a PR about that: facebook/react-native#34058

[kelset]

there's a better PR for it out now: facebook/react-native#34064 let's focus on trying to get this second one in and then decide what to do about mine

[kelset]

commit landed: facebook/react-native@4ea38e1

[fortmarek]

Thanks, already being released now 🚀

[mikehardy]

Partial pick of facebook/react-native@118cf68
Specifically the part that mirrors React pick here facebook/react@6bf3deef5
With goal of ingesting a "react-shallow-renderer" package that supports React 18, since react-native is on React 18 now

This will quiet an install warning (for example when you run yarn)

warning "react-native > react-shallow-renderer@16.14.1" has incorrect peer dependency "react@^16.0.0 || ^17.0.0".

I think the only way to actually do this is to just bump that dependency in package.json to 16.15.0 (and regenerate lock files if lock files are committed? Looks like they are) on the 0.69 branch, but the commit does exist on main already at least

[mikehardy]

Sure seems like just bumping that one dep would be an easy+friendly thing to do 🤔

[Titozzz]

@tido64

FYI --strict-peer-deps fails for other reasons 😅

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: @react-native-community/eslint-config@2.0.0
npm ERR! Found: eslint@7.32.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^7.32.0" from the root project
npm ERR!   peer eslint@">=6" from @react-native-community/eslint-config@2.0.0
npm ERR!   node_modules/@react-native-community/eslint-config
npm ERR!     dev @react-native-community/eslint-config@"^2.0.0" from the root project
npm ERR!   2 more (@typescript-eslint/eslint-plugin, @typescript-eslint/parser)
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! babel-eslint@"^10.1.0" from @react-native-community/eslint-config@2.0.0
npm ERR! node_modules/@react-native-community/eslint-config
npm ERR!   dev @react-native-community/eslint-config@"^2.0.0" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: eslint@8.18.0
npm ERR! node_modules/eslint
npm ERR!   peer eslint@">= 4.12.1" from babel-eslint@10.1.0
npm ERR!   node_modules/babel-eslint
npm ERR!     babel-eslint@"^10.1.0" from @react-native-community/eslint-config@2.0.0
npm ERR!     node_modules/@react-native-community/eslint-config
npm ERR!       dev @react-native-community/eslint-config@"^2.0.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --no-strict-peer-deps, --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/thibault/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/thibault/.npm/_logs/2022-06-29T15_48_34_217Z-debug.log

[cortinico]

Sure seems like just bumping that one dep would be an easy+friendly thing to do 🤔

Can someone do this and send a PR against the release branch? We could potentially include this in 0.69.2

[mikehardy]

I'll see if I can do a PR against the release branch really quickly. This just caused a total failure for me in the npx react-native init case 😩

mike@kunashir:~/work/react-random % npx react-native init RealDeviceTest
Need to install the following packages:
  react-native@0.69.1
Ok to proceed? (y) 
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: undefined@undefined
npm ERR! Found: react-native@0.68.2
npm ERR! node_modules/react-native
npm ERR!   peer react-native@"*" from @react-native-community/cli@7.0.3
npm ERR!   node_modules/@react-native-community/cli
npm ERR!     @react-native-community/cli@"^7.0.3" from react-native@0.68.2
npm ERR!   react-native@"0.69.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! react-native@"0.69.1" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: react@18.0.0
npm ERR! node_modules/react
npm ERR!   peer react@"18.0.0" from react-native@0.69.1
npm ERR!   node_modules/react-native
npm ERR!     react-native@"0.69.1" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/mike/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/mike/.npm/_logs/2022-06-29T20_28_45_100Z-debug-0.log
mike@kunashir:~/work/react-random % npx --version
8.12.0
mike@kunashir:~/work/react-random % node --version
v16.15.1

(doing npx --legacy-peer-deps react-native init NoOneIsReadingThisCommentAreThey? worked but, that hurts a bit)

[mikehardy]

@cortinico 👀 --> facebook/react-native#34104 😄