Add proposal "Publication Helpers and Services" #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explain the difference between helpers and services
|
This proposal was approved in today's meeting, I'll leave it opened a few more weeks before merging it, if anyone wants to chime in before. |
qnga
reviewed
May 18, 2020
|
|
||
| * `linksMatching(predicate: (Link) -> Boolean) -> Link?` | ||
| * Finds all the links matching the given `predicate` in the publication's `readingOrder`, `resources`, and `links` properties (in order). | ||
| * Delegates to `List<Link>::linksMatching()`. |
There was a problem hiding this comment.
I'm afraid providing List<Link> extensions would not look completely natural, since it would not be clear whether alternate links are checked or not (for me extending List suggests not).
There was a problem hiding this comment.
I'm going to rewrite these helpers after we have a working proof-of-concept implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our goal is to improve extensibility and customizability of the
Publicationtype for reading apps. To achieve that, this proposal introduces two structured ways to extend aPublicationwith additional features: helpers and services.See the formatted version here.