Allow to disable display cutouts padding #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mickael-menu @qnga @stevenzeck is there any chance for this being merged anytime soon 🙏 |
|
I plan to test the PR this week, it looks good from what I can tell. |
mickael-menu
approved these changes
Apr 14, 2022
There was a problem hiding this comment.
@szymn Thank you! I took this opportunity for a small refactoring, the R2BasicWebView should not have a direct reference to the navigator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a situation where:
In this scenario we want to avoid additional padding applied for insets within the reader.