Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUB: Fix page swipes while selecting text #143

Merged
merged 2 commits into from Aug 16, 2022
Merged

Conversation

mickael-menu
Copy link
Member

Fixed

Navigator

  • #86 Fixed page swipes while selecting text in an EPUB resource.
  • The onTap event is not sent when an EPUB text selection is active anymore, to prevent showing the app bar while dismissing a selection.

@mickael-menu mickael-menu merged commit 92fd6e8 into develop Aug 16, 2022
@mickael-menu mickael-menu deleted the fix/issue-86 branch August 16, 2022 10:22
@aviashiet
Copy link

Thanks Mickael
Page swipe is fixed but still previous page selection is happening .
Can you suggest for this also that how to stop previous page text selection when selection at top of any page .

@mickael-menu
Copy link
Member Author

I don't know why this is happening and can't reproduce it on my devices, so I have no idea at this point.

@aviashiet
Copy link

Thanks ,May I know on which device you have checked ?

@mickael-menu
Copy link
Member Author

Pixel 3a and 6a

@aviashiet
Copy link

I observe that it works fine on large screen devices like Samsung tabs ,Pixel 3a etc.
on large screens pages are divided in large paragraph as compared to small screen devices , I guess this problem happens only on first small paragraph on top of every pages only.

@aviashiet
Copy link

Hi Mickael,

Have you check this on small screen devices ?

Please suggest as still I am facing this issue on small screen devices .

@mickael-menu
Copy link
Member Author

I don't have smaller devices, but I tried on a Nexus One emulator (3.7") and couldn't reproduce the problem either.

@mickael-menu
Copy link
Member Author

Would you be able to debug the issue yourself as you can reproduce it on one of your devices?

@mickael-menu
Copy link
Member Author

I finally reproduced the issue, but the prospect is not good: #325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants