Skip to content
This repository has been archived by the owner on Jul 29, 2022. It is now read-only.

Spacing is not working #431

Closed
ajay9889 opened this issue Jun 4, 2021 · 4 comments
Closed

Spacing is not working #431

ajay9889 opened this issue Jun 4, 2021 · 4 comments
Labels

Comments

@ajay9889
Copy link

ajay9889 commented Jun 4, 2021

Spacing option is not working first time from user setting "Aa" option dialogue selections

step to reproduce this issue on Android version 2.0.0 latest version

  1. Fresh install the App.
  2. Click on any ePub book to Read
  3. Select the Font setting (Aa) option from the action bar
  4. In Spacing option first time (Justify, left align or right align)
  5. It doesn't change and reflect in the view.
  6. It works when we force close the and restart again.

Expected behavior

It should work as aspected based on the user selections. This is happening in the readium test app as well

@mickael-menu
Copy link
Member

Please next time follow the bug report issue template, as it helps make sure we have all the infos necessary to reproduce an issue.

@stevenzeck
Copy link
Contributor

Yeah for whatever reason the property setProperty("--RS__advancedSettings", "readium-advanced-on"); needs to be set in the root style before that starts to work. Not sure the best place to fix it to be honest.

@mickael-menu
Copy link
Member

mickael-menu commented Jun 9, 2021

Changing the text alignment requires to have the publisher's defaults to OFF (readium-advanced-on).

So the correct behavior should be to automatically switch off the publisher's defaults when changing any "advanced" setting, and apply the CSS together.

See on Swift: https://github.com/readium/r2-testapp-swift/blob/b2db3fd83d14064eedf781074cfd2cf56bfddaa1/r2-testapp-swift/Reader/EPUB/User%20Settings/AdvancedSettingsViewController.swift#L138-L150

@ajay9889
Copy link
Author

It is fixed. thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants