Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getWidthFactor() affects left/right spacing of scroll view differently depending on synthetic spread #103

Closed
danielweck opened this issue Jul 25, 2014 · 3 comments
Closed

getWidthFactor() affects left/right spacing of scroll view differently depending on synthetic spread #103

danielweck opened this issue Jul 25, 2014 · 3 comments

Comments

@danielweck
Copy link
Member

...yet the scroll view is always in single-column mode

https://github.com/readium/readium-js-viewer/blob/develop/lib/ReaderSettingsDialog.js#L27
@danielweck danielweck mentioned this issue Jul 26, 2014
Closed
@danielweck
Copy link
Member Author

Related issue #105

danielweck added a commit that referenced this issue Jul 27, 2014
@danielweck
addresses #101
1c70d43 
reverses commit a40d84f
(will produce pull request to fix the issues separately, see #107 #106 #105 #103)
@danielweck danielweck mentioned this issue Jul 27, 2014
Closed
@danielweck
Copy link
Member Author

Addressed in "textWidthMargins" feature branch (code in readium-share-js so native launchers also work):
https://github.com/readium/readium-js-viewer/tree/feature/textWidthMargins
https://github.com/readium/readium-shared-js/tree/feature/textWidthMargins

@danielweck danielweck added this to the v1 milestone Jul 31, 2014
This was referenced Aug 7, 2014
Merged
Merged
Merged
@danielweck
Copy link
Member Author

Fixed by Pull Request:
readium/readium-shared-js#93
readium/readium-js#68
#151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danielweck