Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hypothes.is annotations: action menu callout (icon buttons) are enabled in TOC view! (dialogs UI as well) #653

Open
danielweck opened this issue Sep 30, 2017 · 3 comments
Open

Hypothes.is annotations: action menu callout (icon buttons) are enabled in TOC view! (dialogs UI as well) #653

danielweck opened this issue Sep 30, 2017 · 3 comments
Assignees
@jccr
Labels
difficulty:Dev func:Highlight func:UX priority:High type:Bug type:Enhancement

Comments

@danielweck
Copy link
Member

Reproduce here:
https://readium.firebaseapp.com/?epub=epub_content%2Faccessible_epub_3&goto=%7B%22idref%22%3A%22id-id2611884%22%2C%22elementCfi%22%3A%22%2F4%2F2%5Bintroduction%5D%2F2%2F1%3A0%22%7D
(open TOC, and see how it is possible to create annotations in the hierarchical list of headings)

So, is it possible to scope the annotator engine?
@danielweck
Copy link
Member Author

danielweck commented Sep 30, 2017 •
edited
Loading

For some reason, annotations in Bootstrap popup modal dialogs are not enabled (e.g. the Readium "about box", or the settings dialog).
Can a similar implicit exclusion technique be used for the TOC panel?

@danielweck
Copy link
Member Author

The modal dialogs are actually affected as well: the Hypothesis callout menu (when selecting text) appears beneath the dialogs due to CSS z-index !

@danielweck danielweck changed the title Hypothes.is annotations: action menu (icon buttons) are enabled in TOC view! Hypothes.is annotations: action menu callout (icon buttons) are enabled in TOC view! (dialogs UI as well) Nov 2, 2017
@jccr jccr mentioned this issue Dec 5, 2017
Open
@danielweck
Copy link
Member Author

Related: #679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jccr jccr

Labels
difficulty:Dev func:Highlight func:UX priority:High type:Bug type:Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danielweck @rkwright @jccr