Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Native apps: Hypothesis plugin is activated by default in the build-output of shared-js #418

Closed
danielweck opened this issue Oct 19, 2017 · 3 comments
Closed

Native apps: Hypothesis plugin is activated by default in the build-output of shared-js #418

danielweck opened this issue Oct 19, 2017 · 3 comments
Labels
difficulty:Dev func:Builds func:Highlight priority:High type:Bug

Comments

@danielweck
Copy link
Member

ReadiumSDK launcher apps include readium-shared-jsvia submodule in order to fetch ./build-output/ single or multiple AMD bundles, unfortunately the Hypothesis plugin is currently activated in order for the cloud reader automatic deployment to Firebase / Surge (via TravisCI) to contain the annotation feature.
@danielweck danielweck mentioned this issue Oct 19, 2017
Closed
@danielweck
Copy link
Member Author

See: readium/readium-js-viewer#657 (comment)

@rkwright
Copy link
Member

@danielweck Isn't this now resolved with the changes to and release of 0.28? If not, what is there left to do here?

@danielweck
Copy link
Member Author

Closed via resolution of readium/readium-js-viewer#658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty:Dev func:Builds func:Highlight priority:High type:Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielweck @rkwright