This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Feature/custom code samples #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| this.setCustomCodeSampleTab = this.setCustomCodeSampleTab.bind(this); | ||
| } | ||
| setCustomCodeSampleTab(index) { |
There was a problem hiding this comment.
How come we need to do this? How come setLanguage() isnt enough?
|
It looks like the coverage has slipped because we're not testing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know js-inspect is failing due to the new way codeSample is now being rendered in Doc. Also a test is failing on Example regarding syntax highlighting not 100% sure how to go forward with that one.