This repository has been archived by the owner on Nov 28, 2022. It is now read-only.
Do not strip trailing slashes and instead create unique key for path URL #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... and revert part of #196 where trailing slashes are stripped from the path URL.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #196, we stripped trailing slashes from path URLs, primarily because it would throw a React key uniqueness error.
Instead of simply using the value of each part to designate the key, this PR will instead create a separate key for each part of the path URL that appends a value count. For example, if there are two values of
/, they will have respective key values of/-0and/-1.