Skip to content

Commit

Permalink
Remove checks for global leaks in Mocha
Browse files Browse the repository at this point in the history
An implementation detail means they drastically slow the test suite down
in Safari and Phantomjs. JSHint should do most of the work catching
unassigned variables.

See: mochajs/mocha#783
  • Loading branch information
aron committed Aug 17, 2013
1 parent 7cffbd1 commit 81d90e0
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions test/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@
</head>
<body>
<div id="mocha"></div>
<script src="./vendor/let.js"></script>
<script src="./vendor/chai.js"></script>
<script src="./vendor/sinon.js"></script>
<script src="./vendor/mocha.js"></script>
<script src="./vendor/mocha.phantom.js"></script>
<script src="../vendor/jquery.js"></script>
<script src="../vendor/underscore.js"></script>
<script src="../vendor/broadcast.js"></script>
Expand All @@ -17,11 +22,6 @@
<script src="../lib/m/sandbox.js"></script>
<script src="../lib/m/events.js"></script>
<script src="../lib/m/module.js"></script>
<script src="./vendor/let.js"></script>
<script src="./vendor/chai.js"></script>
<script src="./vendor/sinon.js"></script>
<script src="./vendor/mocha.js"></script>
<script src="./vendor/mocha.phantom.js"></script>
<script>
mocha.setup({
ui: 'bdd',
Expand All @@ -44,8 +44,8 @@
<script src="./specs/events-spec.js"></script>
<script src="./specs/sandbox-spec.js"></script>
<script>
mocha.checkLeaks();
mocha.globals(['jQuery', '_', 'Broadcast', 'inherit']);
//mocha.checkLeaks();
//mocha.globals(['_', 'jQuery', 'm']);
mocha.run();
</script>
</body>
Expand Down

0 comments on commit 81d90e0

Please sign in to comment.