Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 improvements
1. in ie6,7,8 and opera, insert iframe will cause global leaks
analysis
An iframe could be approached by window[iframeIndex].
In ie6,7,8 and opera, iframeIndex is enumerable, this could cause leaks.
solution
see: lib/runner.js 540
2. in firefox, window.getInterface may cause global leaks
analysis
If runner runs in an iframe, this iframe's window.getInterface method not init at first.
It is assigned in some seconds.
solution
see: lib/runner.js line536
3. in some browsers, mocha.globals([...]) make tests run very slow
analysis
solution