chore(root): update package.json. Update workspaces list #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickhsine
force-pushed
the
main
branch
2 times, most recently
from
e426477
to
96bf7f1
Compare
Remove `packages/embed-code-generator` pkg from `workspaces`. The reason we remove it is because we want `packages/embed-code-generator` to have its own `node_modules`. We don't want it to use the symbolic link to other subpackages. Since we might update other subpackages at the same time, if the codes in other subpackages are not committed and not packaged. embed-code-generator might mistakenly import these undergoing pkgs while building the webpack bundles.
|
因為專案上線時程壓力，我先 merge 這個 PR，之後會再補上 README。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
packages/embed-code-generatorpkg fromworkspaces. The reason we remove it is because we wantpackages/embed-code-generatorto have its ownnode_modules. We don't want it to use the symbolic link to other subpackages.Since we might update other subpackages at the same time, if the codes in other subpackages are not committed and not packaged. embed-code-generator might mistakenly import these ongoing pkgs while building the webpack bundles.