Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(root): update package.json. Update workspaces list #138

Merged
merged 3 commits into from Mar 16, 2023
Merged

chore(root): update package.json. Update workspaces list #138

merged 3 commits into from Mar 16, 2023

Commits on Mar 15, 2023

  1. chore(root): update package.json. Update workspaces list 

    Remove `packages/embed-code-generator` pkg from `workspaces`.
The reason we remove it is because we want `packages/embed-code-generator`
to have its own `node_modules`. We don't want it to use the
symbolic link to other subpackages.

Since we might update other subpackages at the same time,
if the codes in other subpackages are not committed and not packaged.
embed-code-generator might mistakenly import these undergoing pkgs
while building the webpack bundles.
    @nickhsine
    nickhsine committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    689cb5e View commit details
    Browse the repository at this point in the history

  2. chore(ecg): add yarn.lock

    @nickhsine
    nickhsine committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    919fed8 View commit details
    Browse the repository at this point in the history

  3. chore(ecg): add devDependencies

    @nickhsine
    nickhsine committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d99f288 View commit details
    Browse the repository at this point in the history