Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoint: move HTTP header to a GET parameter #138

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Endpoint: move HTTP header to a GET parameter #138

merged 2 commits into from
Sep 20, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 19, 2023

Send api-version= querystring parameter instead of a HTTP header X-RTD-Hosting-Integrations-Version as discussed.

@humitos
Endpoint: move HTTP header to a GET parameter
46a1440 
Send `api-version=` querystring parameter instead of a HTTP header
`X-RTD-Hosting-Integrations-Version` as discussed.

* Requires: readthedocs/readthedocs.org#10753
@humitos humitos requested a review from a team as a code owner September 19, 2023 13:41
@humitos humitos mentioned this pull request Sep 19, 2023
Closed
@humitos
Copy link
Member Author

humitos commented Sep 20, 2023

Weird. Running npm run build locally does not generate any changes 🤷🏼

@humitos humitos merged commit 0beda3b into main Sep 20, 2023
3 of 4 checks passed
@humitos humitos deleted the humitos/header-to-query branch September 20, 2023 10:34
@humitos
Copy link
Member Author

humitos commented Sep 20, 2023

Running npm run build from main after merging does not generate any change either. I'm confused 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@humitos @agjohnson