Addons: move the HTTP header to a GET parameter #10753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move `X-RTD-Hosting-Integration-Version` header to `api-version` querystring parameter. This has some benefits: - make links to this URL clickable (there is no need to use a browser extension to send a specific header in the request) - easier to cache using the default strategy supported by CF Related #10536
humitos
added a commit
to readthedocs/addons
that referenced
this pull request
Sep 19, 2023
Send `api-version=` querystring parameter instead of a HTTP header `X-RTD-Hosting-Integrations-Version` as discussed. * Requires: readthedocs/readthedocs.org#10753
This was referenced Sep 19, 2023
ericholscher
approved these changes
Sep 19, 2023
humitos
added a commit
to readthedocs/addons
that referenced
this pull request
Sep 20, 2023
Send `api-version=` querystring parameter instead of a HTTP header `X-RTD-Hosting-Integrations-Version` as discussed. * Requires: readthedocs/readthedocs.org#10753
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
X-RTD-Hosting-Integration-Versionheader toapi-versionquerystring parameter. This has some benefits:Related #10536