Build: fix API call to version.patch() (#10175)

The attribute in the serializer isn't declared as allow_null=True, so the call to patch fails for projects that aren't using this new feature. This also fixes tests on .com.
readthedocs · Mar 22, 2023 · eadf6ac · eadf6ac
1 parent 2d0dbcb
commit eadf6ac
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/readthedocs/api/v2/serializers.py b/readthedocs/api/v2/serializers.py
@@ -126,7 +126,7 @@ class VersionAdminSerializer(VersionSerializer):
 
     project = ProjectAdminSerializer()
     canonical_url = serializers.SerializerMethodField()
-    build_data = serializers.JSONField(required=False, write_only=True)
+    build_data = serializers.JSONField(required=False, write_only=True, allow_null=True)
 
     def get_canonical_url(self, obj):
         return obj.project.get_docs_url(

diff --git a/readthedocs/proxito/tests/test_hosting.py b/readthedocs/proxito/tests/test_hosting.py
@@ -16,6 +16,7 @@
 @override_settings(
     PUBLIC_DOMAIN="dev.readthedocs.io",
     PUBLIC_DOMAIN_USES_HTTPS=True,
+    GLOBAL_ANALYTICS_CODE=None,
 )
 @pytest.mark.proxito
 class TestReadTheDocsConfigJson(TestCase):