Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pre-commit config and/or some of pre-commit tools need config tightening #11200

Open
yarikoptic opened this issue Mar 8, 2024 · 0 comments
Open

pre-commit config and/or some of pre-commit tools need config tightening #11200

yarikoptic opened this issue Mar 8, 2024 · 0 comments

Comments

@yarikoptic
Copy link
Contributor

What's the problem this feature will solve?

see

illustrating the effect of running pre-commit run --all.
IMHO pre-commit should be configured so running it on the entire codebase without changes results in no new changes.
yarikoptic added a commit to yarikoptic/common that referenced this issue Mar 8, 2024
@yarikoptic
Exclude vendor, .min.js, .svg, and static/*.js from pre-commit
88c6c50 
Those files are copied from other sources or edited by other tools
and IMHO not subject for pre-commit handling.

Refs:
- readthedocs/readthedocs.org#11200
- readthedocs/readthedocs.org#11199
This was referenced Mar 8, 2024
Open
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yarikoptic