Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builds don't run because of setup.py - issue is happening suddenly #3296

Closed
veenamj opened this issue Nov 22, 2017 · 21 comments
Closed

Builds don't run because of setup.py - issue is happening suddenly #3296

veenamj opened this issue Nov 22, 2017 · 21 comments
Labels
Priority: high High priority

Comments

@veenamj
Copy link

veenamj commented Nov 22, 2017

Details

Expected Result

Build should pass

A description of what you wanted to happen
Build should run and pass for some time.

Actual Result

python setup.py install --force
python: can't open file 'setup.py': [Errno 2] No such file or directory
A description of what actually happened

Only for the last 20-24 hours, we are getting the above error that python can't open file setup.py.
Before the last 1 day, all builds ran fine. We did not do any change in there. I am not sure what the actual cause of this problem is. Can anyone please help us out? Thanks in Advance.

@xknat
Copy link

xknat commented Nov 22, 2017

i am having same issue.

@ebertin
Copy link

ebertin commented Nov 22, 2017

Same here. Something appears to be broken.

@krzychb
Copy link

krzychb commented Nov 22, 2017

@safwanrahman
Copy link
Member

Hi,
We have noticed the issue and going to be work on this to fix as soon as possible.

The whole thing is done with volunteering work, so please keep patience.

@RichardLitt RichardLitt added the Priority: high High priority label Nov 22, 2017
@gtalarico
Copy link

Came here to report this. Strange things is, I actually have to RTD pages both pointing to the same Repo, once builds the other stopped building (same settings on both)

Build (failed)
https://readthedocs.org/projects/revitpythonwrapper/builds/6306835/

Build(works)
https://readthedocs.org/projects/rpw/builds/6306827/

image

@humitos
Copy link
Member

humitos commented Nov 22, 2017

@gtalarico one of your build is failing because you have the "Install project" marked

captura de pantalla_2017-11-22_15-21-37

and your project doesn't have a setup.py file.

In the build that it's passing, you don't have that option marked (the setup.py install command is not being executed)

@humitos
Copy link
Member

humitos commented Nov 22, 2017

I would say that the same is happening to @veenamj and @krzychb. Can you all check this and confirm, please?

@gtalarico
Copy link

🤦‍♂️
That was it. I must have selected by accident.
Fixed for me, thanks!

@veenamj
Copy link
Author

veenamj commented Nov 22, 2017

Many thanks @humitos ! The build is working now. I am not sure if all these days that setup.py option was selected or not. So, Im closing this issue.

@veenamj veenamj closed this as completed Nov 22, 2017
@ebertin
Copy link

ebertin commented Nov 22, 2017

Thanks, works fine for me too (used to work before with the virtualenv option although there was no setup.py)!

@agjohnson
Copy link
Contributor

This was discussed in #3095: #3095 (comment)

We don't have a pattern for warning on a particular command failure yet, but ultimately should raise a more helpful error here. Disabling setup.py installation is the correct fix.

@xknat
Copy link

xknat commented Nov 22, 2017

@humitos this fixed my issue,
i am sure more users will be having same issue as it did work in the past and i did not change any settings at all.

without changing advanced settings it would still try to run the setup....

good work tho~!

@agjohnson
Copy link
Contributor

You would have had to enable this option in the past, it's not on by default. The previous behavior was to silently pass even if there was no setup.py, so you wouldn't have noticed this if you did turn it on

@gtalarico
Copy link

That makes sense
But even tough it was silenced, the old builds were going through
The recent nonnsilent failures were keeping the new builds from going through (docs were not updating)

@krzychb
Copy link

krzychb commented Nov 23, 2017

@safwanrahman, @humitos:

Thank your for checking this issue and clarification.

The build failure is now gone and this is a great news!

Why original builds below were reported as "Passesd" or "Build completed" (green) while actually they failed?

  1. https://readthedocs.org/projects/esp-idf/builds/6303064/
  2. https://readthedocs.org/projects/esp-idf/builds/6302622/
  3. https://readthedocs.org/projects/esp-idf/builds/6298978/

image

@humitos
Copy link
Member

humitos commented Nov 23, 2017

@krzychb that's another issue and should be fixed after #3293 and/or #3292

@krzychb
Copy link

krzychb commented Nov 23, 2017

Sounds good. I am happy to see you have it already in the pipeline.
Looking forward to see both PR merged!

Will these PRs also cover a case when a build is stuck in "Building" state for several hours?
https://readthedocs.org/projects/esp-idf/builds/6308479/
https://readthedocs.org/projects/esp-idf/builds/6308480/
https://readthedocs.org/projects/esp-idf/builds/6308949/

image

@humitos
Copy link
Member

humitos commented Nov 23, 2017

Don't think so.

If something bad happened and the build didn't update its status, I think it will never do it, ha. I'm not sure anyway (maybe there is a task or something that I'm not familiar with).

Those PR won't make that happen again "in theory".

@Tareque2208
Copy link

Where is this advance settings for :
33148218-fb06aec6-cf98-11e7-945a-97d1a95cc114

@stsewd
Copy link
Member

stsewd commented Feb 27, 2018

@Tareque16 go to the admin panel of your project, and then to advanced settings.

@svenevs
Copy link

svenevs commented Apr 18, 2018

redacted. The observed behavior, though confusing, is arguably correct. I forgot that my repo had a readthedocs.yml:

formats:
    - none

python:
    version: 3
    pip_install: true  # <- triggers search for setup.py, set to false

So even though on my advanced admin page I did not have the "Install your project ..." checked, I needed to indicate this action in readthedocs.yml: pip_install: false.

Sorry for the noise, but maybe this will help somebody one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: high High priority
Projects
None yet
Development

No branches or pull requests