Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Privacy levels on the .org #3781

Closed
ericholscher opened this issue Mar 12, 2018 · 5 comments
Closed

Hide Privacy levels on the .org #3781

ericholscher opened this issue Mar 12, 2018 · 5 comments
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Milestone

Comments

@ericholscher
Copy link
Member

Currently we are still exposing privacy levels to users, but they don't work as intended. A refactor a long time ago broke "private" versions on the .org, and we don't have any real reason to support them, since all the branches are open source & public.

We should hide the UI around privacy levels, so that users stop setting things to private and then having them break.

@ericholscher ericholscher added the Needed: design decision A core team decision is required label Mar 12, 2018
@stsewd
Copy link
Member

stsewd commented Mar 13, 2018

Related #2663

@agjohnson agjohnson added this to the Admin UX milestone Sep 19, 2018
@agjohnson agjohnson added Improvement Minor improvement to code Accepted Accepted issue on our roadmap and removed Needed: design decision A core team decision is required labels Sep 19, 2018
@dojutsu-user
Copy link
Member

dojutsu-user commented Nov 9, 2018

Is this still open?
I would like to take this issue up.
And just for confirmation...
this needs to be removed

screenshot from 2018-11-09 22-29-11

right?

@ericholscher
Copy link
Member Author

Yea, there is a good bit of work and thinking required here, so I wouldn't start on it right away. We need to account for all the projects that have set non-default privacy levels, because removing the UI would make it impossible for them to change it. We also should figure out if we want this logic in the .org at all, or if we want to move it all into the .com as extensions somehow.

@dojutsu-user
Copy link
Member

@ericholscher
One suggestion, we can remove the UI for the users which have default option set (i.e. PUBLIC) and for the other users, we can show a warning in the Advanced Settings saying something like this -
It is recommended to change your Privacy Level to Public.

@stsewd
Copy link
Member

stsewd commented Apr 29, 2020

We already hide version privacy levels, the only missing thing is #2663

@stsewd stsewd closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
None yet
Development

No branches or pull requests

4 participants