AdminPermission is_admin permission mismatch with views permissions

[xrmx]

Details

If i am a superuser i see all the content that is guarded by the is_admin template tag even if i am not an admin of the project. is_admin is just a wrapper of core.permissions. AdminPermission and in fact the behavior matches the code.
The problem is that this access control does not match the one in the build views. e.g. In the project detail page i see the build version button but when i click it i get a 404. Same for updating project details.
Any idea on how to fix this?

Expected Result

As a superuser if i cannot build a project i shouldn't see the button for doing so

Actual Result

As a superuser a button that leds to a 404 is showed to me

[humitos]

Being a super user we can trigger builds from another projects (I've been doing that) but the problem you mentioned is with the "Admin" button that it's shown but when clicked you see a 404.

The trigger button was fixed by @davidfischer at #4207

I think that Admin button shouldn't be shown at all.

[xrmx]

@humitos missed that, thanks! Will check and close the bug if that's it.

[xrmx]

For us it's not just the project admin button it's also the link to projects.views.private.project_version_detail for each version.

[xrmx]

We would like being able to inspect our users projects, are you willing to consider a PR that permit that? Like what David did but for the other two views.

[xrmx]

We need something like this italia@5a76034

We need to add another method to the queryset manager because for_admin_user is also used when we need to really pick projects from the user, e.g. import views.

[humitos]

In that case, this needs a deeper look since we extend the for_admin_user in our corporate site (to respect another kind of permissions) and we will need to make sure that is still supported after the changes needed for this here.

[xrmx]

So this is what i come up:
italia#89

First commit is backport of David fix, the second does the same to more views and the last add the new queryset method that calls the old one so it may work even with your overridings. If it is interesting for you i can open a PR upstream of course.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[xrmx]

I think this is still valid

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stsewd]

We are planning in refactor the auth code, so it's easier to use/extend. Not sure if we should re-open this issue or wait for the refactor.