Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove asserts from code #5433

Closed
stsewd opened this issue Mar 11, 2019 · 1 comment
Closed

Remove asserts from code #5433

stsewd opened this issue Mar 11, 2019 · 1 comment
Labels
Improvement Minor improvement to code
Milestone
Cleanup

Comments

@stsewd
Copy link
Member

stsewd commented Mar 11, 2019

We have some asserts statements outside our tests, we should remove them and replace them with a more explicit check and raise an exception or remove them at all, it may depend on the place of the code.

See https://bandit.readthedocs.io/en/latest/plugins/b101_assert_used.html
@stsewd stsewd added the Improvement Minor improvement to code label Mar 11, 2019
@stsewd stsewd added this to the Cleanup milestone Mar 11, 2019
@dojutsu-user
Copy link
Member

Working on it.

@dojutsu-user dojutsu-user mentioned this issue Mar 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
Cleanup
Development

No branches or pull requests
2 participants
@stsewd @dojutsu-user