Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banners don't render nicely depending on Project CSS #5563

Closed
koaning opened this issue Apr 3, 2019 · 3 comments · Fixed by #5731
Closed

Banners don't render nicely depending on Project CSS #5563

koaning opened this issue Apr 3, 2019 · 3 comments · Fixed by #5731
Assignees
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related

Comments

@koaning
Copy link

koaning commented Apr 3, 2019

Howdy.

I'm digging your service (it seems to work a bit nicer than github pages for my project) which I why I'd like to notify you of a possible optimisation for your ads. I have a sphinx template with a custom css which makes the text of your banner slightly hard to read.

image

Details

Expected Result

The text might become hard to read depending on my custom css settings.

Actual Result

The css might be able to change based on the background color?

@humitos humitos assigned humitos and davidfischer and unassigned humitos Apr 3, 2019
@stsewd stsewd added the Design Design or UX/UI related label Apr 3, 2019
@stale
Copy link

stale bot commented May 18, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label May 18, 2019
@koaning
Copy link
Author

koaning commented May 19, 2019

@davidfischer this is a ping, just to check if this is on your roadmap. i am pining you because @humitos assigned you.

@stale stale bot removed the Status: stale Issue will be considered inactive soon label May 19, 2019
@davidfischer davidfischer added the Accepted Accepted issue on our roadmap label May 20, 2019
@davidfischer
Copy link
Contributor

@koaning I will be the one working on this. It isn't the top of my queue but I should get to it in the next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Design Design or UX/UI related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants