Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how we build badge_only.css #8247

Closed
ericholscher opened this issue Jun 9, 2021 · 1 comment
Closed

Refactor how we build badge_only.css #8247

ericholscher opened this issue Jun 9, 2021 · 1 comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: design decision A core team decision is required

Comments

@ericholscher
Copy link
Member

Currently we embed https://github.com/readthedocs/readthedocs.org/blob/4083525f338130ade975b51076c776a2a5600e7e/media/css/badge_only.css on documentation pages that aren't our theme. This is so we can show the flyout to these users. We also ship a version of the flyout in the RTD theme itself. We should figure out a plan to making the flyout fully styled outside of the RTD theme, and let any theme override it.

This would allow us to fully ship the CSS for the flyout as part of RTD, and remove the dependency on the theme from the larger platform.

@stsewd stsewd added Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: design decision A core team decision is required labels Jun 9, 2021
@humitos
Copy link
Member

humitos commented Jul 24, 2023

This work is being done in readthedocs/addons#66. Once we deploy the new flyout we will be able to remove all these files that we are injecting --which is tracked in readthedocs/addons#72

@humitos humitos closed this as completed Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

No branches or pull requests

3 participants