Proxito: allow to serve external version on development #10241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we are using `.devthedocs.org` and `.build.devthedocs.org`, the public domain is included in the external domain --this does not happen in production. So, in local development this makes the PR to not be served and detected as a "Weird variation of our domain".
|
@ericholscher maybe is it worth to use another domain for external versions on development? |
|
Seems like we can just make this check smarter? We should just check for |
Yeah, we could split the domain in |
stsewd
added a commit
that referenced
this pull request
Apr 19, 2023
During development we use overlapping domains: - devthedocs.org - build.devthedocs.org Closes #10241
stsewd
added a commit
that referenced
this pull request
Apr 20, 2023
During development, we use overlapping domains: - devthedocs.org - build.devthedocs.org Basically now the suspicious hostname checks are done after the public and external version domains have been tried, and before resolving a custom domain. Closes #10241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are using
.devthedocs.organd.build.devthedocs.org, the public domain is included in the external domain --this does not happen in production.So, in local development this makes the PR to not be served and detected as a "Weird variation of our domain".
I'm not 100% sure this is the correct fix or it needs to handle other cases, but at least this solves my problem locally. @stsewd I know you have been working on all this code; feel free to adapt it in case there is something missing.