API V3: clean version when deactivated and build version when activated #10308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaoming
approved these changes
May 11, 2023
readthedocs/api/v3/views.py
Outdated
| if not was_active and version.active: | ||
| trigger_build(project=version.project, version=version) | ||
| # Purge the cache from the CDN. | ||
| version_changed.send(sender=self.__class__, version=version) |
There was a problem hiding this comment.
That seems like an additional bug fix in the mix 馃憤
humitos
reviewed
May 11, 2023
benjaoming
reviewed
May 16, 2023
Co-authored-by: Benjamin Balder Bach <benjamin@readthedocs.org>
stsewd
requested review from
agjohnson
and removed request for
a team and
agjohnson
humitos
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches what we do in our version form.
Closes #10221.
馃摎 Documentation previews 馃摎
docs): https://docs--10308.org.readthedocs.build/en/10308/dev): https://dev--10308.org.readthedocs.build/en/10308/