Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: note explaining build.apt_packages doesn't work with build.commands #10347

Merged
merged 2 commits into from May 24, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented May 24, 2023

Add a small note communicating these two configs don't work together.

Reference: #9599 (comment)


📚 Documentation previews 📚

…ommands`

Add a small note communicating these two configs don't work together.
@humitos humitos requested review from a team as code owners May 24, 2023 06:46
@humitos humitos requested a review from benjaoming May 24, 2023 06:46
Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an extra fix, but otherwise LGTM

docs/user/config-file/v2.rst Outdated Show resolved Hide resolved
@benjaoming
Copy link
Contributor

@humitos the PR updates the common submodule now, trying to smuggle in a change? :)

@humitos
Copy link
Member Author

humitos commented May 24, 2023

That's a mistake. It was in the original commit, tho. In any case, seems fine to update common/, tho.

@humitos humitos merged commit 38c1fcc into main May 24, 2023
4 of 5 checks passed
@humitos humitos deleted the humitos/config-v2-build-apt_packages branch May 24, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants