Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation: show the project slug/link correctly on email #10432

Merged
merged 1 commit into from Jun 13, 2023
Merged

Deprecation: show the project slug/link correctly on email #10432

merged 1 commit into from Jun 13, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Jun 13, 2023

Small fixes to generate the URL correctly.

@humitos
Deprecation: show the project slug/link correctly on email
e55bab4 
Small fixes to generate the URL correctly.
@humitos humitos added the PR: hotfix Pull request applied as hotfix to release label Jun 13, 2023
@humitos humitos requested a review from a team as a code owner June 13, 2023 17:43
@humitos humitos requested a review from benjaoming June 13, 2023 17:43
ericholscher
ericholscher approved these changes Jun 13, 2023
View reviewed changes
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@humitos humitos merged commit fe22c00 into main Jun 13, 2023
7 checks passed
@humitos humitos deleted the humitos/email-notification-fix branch June 13, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@benjaoming benjaoming Awaiting requested review from benjaoming benjaoming is a code owner automatically assigned from readthedocs/backend

Assignees

@humitos humitos

Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@humitos @ericholscher